Fix monitoring-plugin on podman #357
Conversation
openshift-ci
bot
added
the
approved
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 44.18% 44.19% +0.01%
==========================================
Files 54 54
Lines 4117 4116 -1
==========================================
Hits 1819 1819
+ Misses 2033 2032 -1
Partials 265 265
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexVulaj, cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
bug
What this PR does / Why we need it?
This fixes a bug where if
ce.putFileToMountencountered an error, it wouldn't be passed through. This resulted in a situation where the monitoring plugin wouldn't start, but no error would be passed (even with debug).It also fixes the root bug that was causing
ce.putFileToMountto fail. Thepodman machine sshcommand requires the name of the machine you are SSH'ing into to be specified if you are putting an in-line command command.Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Pre-checks (if applicable)